From b41968da3674eae702a4765a3dbed47ac99a91b8 Mon Sep 17 00:00:00 2001 From: KMY Date: Thu, 2 Mar 2023 22:10:12 +0900 Subject: [PATCH 1/5] Fix status meaningless space --- app/javascript/mastodon/components/status.jsx | 4 +++- .../mastodon/features/status/components/detailed_status.jsx | 4 +++- app/javascript/styles/mastodon/components.scss | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/javascript/mastodon/components/status.jsx b/app/javascript/mastodon/components/status.jsx index 3d920bdb79..de1e9390c9 100644 --- a/app/javascript/mastodon/components/status.jsx +++ b/app/javascript/mastodon/components/status.jsx @@ -512,7 +512,9 @@ class Status extends ImmutablePureComponent { let emojiReactionsBar = null; if (!this.props.withoutEmojiReactions && status.get('emoji_reactions')) { const emojiReactions = status.get('emoji_reactions'); - emojiReactionsBar = ; + if (emojiReactions.size > 0) { + emojiReactionsBar = ; + } } return ( diff --git a/app/javascript/mastodon/features/status/components/detailed_status.jsx b/app/javascript/mastodon/features/status/components/detailed_status.jsx index dae935ceb5..e864ced944 100644 --- a/app/javascript/mastodon/features/status/components/detailed_status.jsx +++ b/app/javascript/mastodon/features/status/components/detailed_status.jsx @@ -194,7 +194,9 @@ class DetailedStatus extends ImmutablePureComponent { let emojiReactionsBar = null; if (status.get('emoji_reactions')) { const emojiReactions = status.get('emoji_reactions'); - emojiReactionsBar = ; + if (emojiReactions.size > 0) { + emojiReactionsBar = ; + } } if (status.get('application')) { diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss index 4364b8ebd6..538044340c 100644 --- a/app/javascript/styles/mastodon/components.scss +++ b/app/javascript/styles/mastodon/components.scss @@ -1269,7 +1269,7 @@ body > [data-popper-placement] { margin: 8px 0 2px 4px; .emoji-reactions-bar__button { - background: lighten($ui-base-color, 16%); + background: lighten($ui-base-color, 12%); border: 0; cursor: pointer; display: flex; From bc64450455d742fcea18db79bc61cfa3fbe5516b Mon Sep 17 00:00:00 2001 From: KMY Date: Thu, 2 Mar 2023 22:48:37 +0900 Subject: [PATCH 2/5] Fix notification failed bug --- .../mastodon/features/notifications/components/filter_bar.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/javascript/mastodon/features/notifications/components/filter_bar.jsx b/app/javascript/mastodon/features/notifications/components/filter_bar.jsx index f56ca6a69c..9fb06c1ddc 100644 --- a/app/javascript/mastodon/features/notifications/components/filter_bar.jsx +++ b/app/javascript/mastodon/features/notifications/components/filter_bar.jsx @@ -6,6 +6,7 @@ import Icon from 'mastodon/components/icon'; const tooltips = defineMessages({ mentions: { id: 'notifications.filter.mentions', defaultMessage: 'Mentions' }, favourites: { id: 'notifications.filter.favourites', defaultMessage: 'Favourites' }, + emojiReactions: { id: 'notifications.filter.emoji_reactions', defaultMessage: 'Emoji reactions' }, boosts: { id: 'notifications.filter.boosts', defaultMessage: 'Boosts' }, polls: { id: 'notifications.filter.polls', defaultMessage: 'Poll results' }, follows: { id: 'notifications.filter.follows', defaultMessage: 'Follows' }, @@ -79,7 +80,7 @@ class FilterBar extends React.PureComponent { onClick={this.onClick('emoji_reaction')} title={intl.formatMessage(tooltips.emojiReactions)} > - +