balkan/nas
1
0
Fork 0
forked from gitea/nas
Code Pull requests Activity

Refactor of API timeline actions (#3263)

Browse source 
- Increase coverage to exercise all parts of each action
- Move into namespace to share common code
- Misc refactor of each action for smaller methods, simpler code
This commit is contained in:
Matt Jankowski 2017-05-23 12:11:39 -04:00 • committed by Eugen Rochko
parent 256e3adc1d
commit 4289ed1d13
11 changed files with 298 additions and 97 deletions
Download patch file Download diff file Expand all files Collapse all files

65
spec/controllers/api/v1/timelines_controller_spec.rb
View file

@ -1,65 +0,0 @@
require 'rails_helper'
RSpec.describe Api::V1::TimelinesController, type: :controller do
render_views
let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
before do
allow(controller).to receive(:doorkeeper_token) { token }
end
context 'with a user context' do
let(:token) { double acceptable?: true, resource_owner_id: user.id }
describe 'GET #home' do
it 'returns http success' do
get :home
expect(response).to have_http_status(:success)
end
end
describe 'GET #public' do
it 'returns http success' do
get :public
expect(response).to have_http_status(:success)
end
end
describe 'GET #tag' do
before do
PostStatusService.new.call(user.account, 'It is a #test')
end
it 'returns http success' do
get :tag, params: { id: 'test' }
expect(response).to have_http_status(:success)
end
end
end
context 'without a user context' do
let(:token) { double acceptable?: true, resource_owner_id: nil }
describe 'GET #home' do
it 'returns http unprocessable entity' do
get :home
expect(response).to have_http_status(:unprocessable_entity)
end
end
describe 'GET #public' do
it 'returns http success' do
get :public
expect(response).to have_http_status(:success)
end
end
describe 'GET #tag' do
it 'returns http success' do
get :tag, params: { id: 'test' }
expect(response).to have_http_status(:success)
end
end
end
end