Improve RuboCop rules (compatibility to Code Climate) (#3636)

08f8de84eb/Gemfile.lock (L38)
Code Climate is using RuboCop v0.46.0.

Change several rules to maintain compatibility.
This commit is contained in:
Yamagishi Kazutoshi 2017-06-08 20:24:28 +09:00 committed by Eugen Rochko
parent 7d2b4186c3
commit 0a0b9a271a
12 changed files with 33 additions and 14 deletions

View file

@ -16,7 +16,7 @@ class FetchAtomService < BaseService
return nil if response.code != 200
return [url, fetch(url)] if response.mime_type == 'application/atom+xml'
return process_headers(url, response) unless response['Link'].blank?
return process_headers(url, response) if response['Link'].present?
process_html(fetch(url))
rescue OpenSSL::SSL::SSLError => e
Rails.logger.debug "SSL error: #{e}"

View file

@ -23,7 +23,7 @@ class SuspendAccountService < BaseService
@account.notifications,
@account.favourites,
@account.active_relationships,
@account.passive_relationships
@account.passive_relationships,
].each do |association|
destroy_all(association)
end

View file

@ -24,7 +24,7 @@ class UpdateRemoteProfileService < BaseService
end
old_hub_url = account.hub_url
account.hub_url = hub_link['href'] if !hub_link.nil? && !hub_link['href'].blank? && (hub_link['href'] != old_hub_url)
account.hub_url = hub_link['href'] if !hub_link.nil? && hub_link['href'].present? && (hub_link['href'] != old_hub_url)
account.save_with_optional_media!