gitea/nas
1
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Reduce factory creation (132 -> 40) in lib/vacuum/* specs (#32498)

Browse source
This commit is contained in:
Matt Jankowski 2024-10-15 08:54:56 -04:00 • committed by GitHub
parent d74c2c583a
commit 0cc21f1ded
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 41 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

13
spec/lib/vacuum/backups_vacuum_spec.rb
View file

@ -11,16 +11,13 @@ RSpec.describe Vacuum::BackupsVacuum do
let!(:expired_backup) { Fabricate(:backup, created_at: (retention_period + 1.day).ago) }
let!(:current_backup) { Fabricate(:backup) }
before do
it 'deletes backups past the retention period but preserves those within the period' do
subject.perform
end
it 'deletes backups past the retention period' do
expect { expired_backup.reload }.to raise_error ActiveRecord::RecordNotFound
end
it 'does not delete backups within the retention period' do
expect { current_backup.reload }.to_not raise_error
expect { expired_backup.reload }
.to raise_error ActiveRecord::RecordNotFound
expect { current_backup.reload }
.to_not raise_error
end
end
end