From 0d5123199f93546859c45f93ee8906d4c06e59b4 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Mon, 2 Jun 2025 03:37:33 -0400 Subject: [PATCH] Fix `Style/FormatStringToken` cop (#34861) --- .rubocop_todo.yml | 9 --------- config/initializers/devise.rb | 2 +- lib/paperclip/color_extractor.rb | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d8b1448321..d77232c06f 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -39,15 +39,6 @@ Style/FetchEnvVar: - 'config/initializers/paperclip.rb' - 'lib/tasks/repo.rake' -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, MaxUnannotatedPlaceholdersAllowed, Mode, AllowedMethods, AllowedPatterns. -# SupportedStyles: annotated, template, unannotated -# AllowedMethods: redirect -Style/FormatStringToken: - Exclude: - - 'config/initializers/devise.rb' - - 'lib/paperclip/color_extractor.rb' - # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: diff --git a/config/initializers/devise.rb b/config/initializers/devise.rb index 6ea69e31bb..f69f7519c8 100644 --- a/config/initializers/devise.rb +++ b/config/initializers/devise.rb @@ -394,7 +394,7 @@ Devise.setup do |config| config.ldap_uid = ENV.fetch('LDAP_UID', 'cn') config.ldap_mail = ENV.fetch('LDAP_MAIL', 'mail') config.ldap_tls_no_verify = ENV['LDAP_TLS_NO_VERIFY'] == 'true' - config.ldap_search_filter = ENV.fetch('LDAP_SEARCH_FILTER', '(|(%{uid}=%{email})(%{mail}=%{email}))') + config.ldap_search_filter = ENV.fetch('LDAP_SEARCH_FILTER', '(|(%s=%s)(%s=%s))') config.ldap_uid_conversion_enabled = ENV['LDAP_UID_CONVERSION_ENABLED'] == 'true' config.ldap_uid_conversion_search = ENV.fetch('LDAP_UID_CONVERSION_SEARCH', '.,- ') config.ldap_uid_conversion_replace = ENV.fetch('LDAP_UID_CONVERSION_REPLACE', '_') diff --git a/lib/paperclip/color_extractor.rb b/lib/paperclip/color_extractor.rb index fba32ba4cb..e0cdfdb523 100644 --- a/lib/paperclip/color_extractor.rb +++ b/lib/paperclip/color_extractor.rb @@ -239,7 +239,7 @@ module Paperclip end def rgb_to_hex(rgb) - format('#%02x%02x%02x', rgb.r, rgb.g, rgb.b) + format('#%02x%02x%02x', rgb.r, rgb.g, rgb.b) # rubocop:disable Style/FormatStringToken end end end