Clean up well-known routes/controllers (#1649)

* Add request spec for host meta route returning xml

* Add routing spec for xrd routes

* Update well-known routes

* Move webfinger and host-meta actions to their own controllers
This commit is contained in:
Matt Jankowski 2017-04-13 07:09:07 -04:00 committed by Eugen
parent 3a9eb81a80
commit 137100dcf3
12 changed files with 119 additions and 83 deletions

View file

@ -0,0 +1,13 @@
require 'rails_helper'
describe WellKnown::HostMetaController, type: :controller do
render_views
describe 'GET #show' do
it 'returns http success' do
get :show, format: :xml
expect(response).to have_http_status(:success)
end
end
end

View file

@ -0,0 +1,21 @@
require 'rails_helper'
describe WellKnown::WebfingerController, type: :controller do
render_views
describe 'GET #show' do
let(:alice) { Fabricate(:account, username: 'alice') }
it 'returns http success when account can be found' do
get :show, params: { resource: alice.to_webfinger_s }, format: :json
expect(response).to have_http_status(:success)
end
it 'returns http not found when account cannot be found' do
get :show, params: { resource: 'acct:not@existing.com' }, format: :json
expect(response).to have_http_status(:not_found)
end
end
end

View file

@ -1,26 +0,0 @@
require 'rails_helper'
RSpec.describe XrdController, type: :controller do
render_views
describe 'GET #host_meta' do
it 'returns http success' do
get :host_meta
expect(response).to have_http_status(:success)
end
end
describe 'GET #webfinger' do
let(:alice) { Fabricate(:account, username: 'alice') }
it 'returns http success when account can be found' do
get :webfinger, params: { resource: alice.to_webfinger_s }, format: :json
expect(response).to have_http_status(:success)
end
it 'returns http not found when account cannot be found' do
get :webfinger, params: { resource: 'acct:not@existing.com' }, format: :json
expect(response).to have_http_status(:not_found)
end
end
end

View file

@ -0,0 +1,12 @@
require "rails_helper"
describe "The host_meta route" do
describe "requested without accepts headers" do
it "returns an xml response" do
get host_meta_url
expect(response).to have_http_status(:success)
expect(response.content_type).to eq "application/xrd+xml"
end
end
end

View file

@ -0,0 +1,15 @@
require 'rails_helper'
describe 'the host-meta route' do
it 'routes to correct place with xml format' do
expect(get('/.well-known/host-meta')).
to route_to('well_known/host_meta#show', format: 'xml')
end
end
describe 'the webfinger route' do
it 'routes to correct place with json format' do
expect(get('/.well-known/webfinger')).
to route_to('well_known/webfinger#show', format: 'json')
end
end