Merge remote-tracking branch 'parent/main' into upstream-20240830

spec/requests/api/v2_alpha/notifications_spec.rb

@@ -35,6 +35,17 @@ RSpec.describe 'Notifications' do
       end
     end
 
+    context 'with grouped_types parameter' do
+      let(:params) { { grouped_types: %w(reblog) } }
+
+      it 'returns expected notifications count' do
+        subject
+
+        expect(response).to have_http_status(200)
+        expect(body_as_json[:count]).to eq 5
+      end
+    end
+
     context 'with a read marker' do
       before do
         id = user.account.notifications.browserable.order(id: :desc).offset(2).first.id
@@ -114,6 +125,38 @@ RSpec.describe 'Notifications' do
       end
     end
 
+    context 'with grouped_types param' do
+      let(:params) { { grouped_types: %w(reblog) } }
+
+      it 'returns everything, but does not group favourites' do
+        subject
+
+        expect(response).to have_http_status(200)
+        expect(body_as_json[:notification_groups]).to contain_exactly(
+          a_hash_including(
+            type: 'reblog',
+            sample_account_ids: [bob.account_id.to_s]
+          ),
+          a_hash_including(
+            type: 'mention',
+            sample_account_ids: [bob.account_id.to_s]
+          ),
+          a_hash_including(
+            type: 'favourite',
+            sample_account_ids: [bob.account_id.to_s]
+          ),
+          a_hash_including(
+            type: 'favourite',
+            sample_account_ids: [tom.account_id.to_s]
+          ),
+          a_hash_including(
+            type: 'follow',
+            sample_account_ids: [bob.account_id.to_s]
+          )
+        )
+      end
+    end
+
     context 'with exclude_types param' do
       let(:params) { { exclude_types: %w(mention) } }
 

spec/requests/media_spec.rb

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Media' do
+  describe 'GET /media/:id' do
+    context 'when the media attachment does not exist' do
+      it 'responds with not found' do
+        get '/media/missing'
+
+        expect(response)
+          .to have_http_status(404)
+      end
+    end
+
+    context 'when the media attachment has a shortcode' do
+      let(:media_attachment) { Fabricate :media_attachment, status: status, shortcode: 'OI6IgDzG-nYTqvDQ994' }
+
+      context 'when attached to a status' do
+        let(:status) { Fabricate :status }
+
+        it 'redirects to file url' do
+          get medium_path(id: media_attachment.shortcode)
+
+          expect(response)
+            .to redirect_to(media_attachment.file.url(:original))
+        end
+      end
+
+      context 'when not attached to a status' do
+        let(:status) { nil }
+
+        it 'responds with not found' do
+          get medium_path(id: media_attachment.shortcode)
+
+          expect(response)
+            .to have_http_status(404)
+        end
+      end
+
+      context 'when attached to non-public status' do
+        let(:status) { Fabricate :status, visibility: :direct }
+
+        it 'responds with not found' do
+          get medium_path(id: media_attachment.shortcode)
+
+          expect(response)
+            .to have_http_status(404)
+        end
+      end
+    end
+
+    context 'when the media attachment does not have a shortcode' do
+      let(:media_attachment) { Fabricate :media_attachment, status: status, shortcode: nil }
+
+      context 'when attached to a status' do
+        let(:status) { Fabricate :status }
+
+        it 'redirects to file url' do
+          get medium_path(id: media_attachment.id)
+
+          expect(response)
+            .to redirect_to(media_attachment.file.url(:original))
+        end
+      end
+
+      context 'when not attached to a status' do
+        let(:status) { nil }
+
+        it 'responds with not found' do
+          get medium_path(id: media_attachment.id)
+
+          expect(response)
+            .to have_http_status(404)
+        end
+      end
+
+      context 'when attached to non-public status' do
+        let(:status) { Fabricate :status, visibility: :direct }
+
+        it 'responds with not found' do
+          get medium_path(id: media_attachment.id)
+
+          expect(response)
+            .to have_http_status(404)
+        end
+      end
+    end
+  end
+end