Fix handling of malformed/unusual HTML (#34201)

This commit is contained in:
Claire 2025-03-18 15:50:41 +01:00 committed by KMY
parent b84d2fc860
commit 21812a0a78
4 changed files with 38 additions and 8 deletions

View file

@ -73,7 +73,14 @@ class Account::Field < ActiveModelSerializers::Model
end
def extract_url_from_html
doc = Nokogiri::HTML5.fragment(value)
begin
doc = Nokogiri::HTML5.fragment(value)
rescue ArgumentError
# This can happen if one of the Nokogumbo limits is encountered
# Unfortunately, it does not use a more precise error class
# nor allows more graceful handling
return
end
return if doc.nil?
return if doc.children.size != 1