diff --git a/lib/sanitize_ext/sanitize_config.rb b/lib/sanitize_ext/sanitize_config.rb
index dc39e9c90f..9cc500c36e 100644
--- a/lib/sanitize_ext/sanitize_config.rb
+++ b/lib/sanitize_ext/sanitize_config.rb
@@ -51,29 +51,22 @@ class Sanitize
end
UNSUPPORTED_ELEMENTS_TRANSFORMER = lambda do |env|
- return unless %w(h1 h2 h3 h4 h5 h6 blockquote pre ul ol li).include?(env[:node_name])
+ return unless %w(h1 h2 h3 h4 h5 h6).include?(env[:node_name])
current_node = env[:node]
- case env[:node_name]
- when 'li'
- current_node.traverse do |node|
- next unless %w(p ul ol li).include?(node.name)
-
- node.add_next_sibling('
') if node.next_sibling
- node.replace(node.children) unless node.text?
- end
- else
- current_node.name = 'p'
- end
+ current_node.name = 'strong'
+ current_node.wrap('
')
end
MASTODON_STRICT ||= freeze_config(
- elements: %w(p br span a),
+ elements: %w(p br span a del pre blockquote code b strong u i em ul ol li),
attributes: {
'a' => %w(href rel class),
'span' => %w(class),
+ 'ol' => %w(start reversed),
+ 'li' => %w(value),
},
add_attributes: {
diff --git a/spec/lib/sanitize_config_spec.rb b/spec/lib/sanitize_config_spec.rb
index c9543ceb0c..a01122bed0 100644
--- a/spec/lib/sanitize_config_spec.rb
+++ b/spec/lib/sanitize_config_spec.rb
@@ -6,24 +6,16 @@ describe Sanitize::Config do
describe '::MASTODON_STRICT' do
subject { Sanitize::Config::MASTODON_STRICT }
- it 'converts h1 to p' do
- expect(Sanitize.fragment('Foo
', subject)).to eq 'Foo
'
+ it 'converts h1 to p strong' do
+ expect(Sanitize.fragment('Foo
', subject)).to eq 'Foo
'
end
- it 'converts ul to p' do
- expect(Sanitize.fragment('Check out:
', subject)).to eq 'Check out:
Foo
Bar
'
+ it 'keeps ul' do
+ expect(Sanitize.fragment('Check out:
', subject)).to eq 'Check out:
'
end
- it 'converts p inside ul' do
- expect(Sanitize.fragment('', subject)).to eq 'Foo
Bar
Baz
'
- end
-
- it 'converts ul inside ul' do
- expect(Sanitize.fragment('', subject)).to eq 'Foo
Bar
Baz
'
- end
-
- it 'keep links in lists' do
- expect(Sanitize.fragment('Check out:
', subject)).to eq 'Check out:
joinmastodon.org
Bar
'
+ it 'keeps start and reversed attributes of ol' do
+ expect(Sanitize.fragment('Check out:
- Foo
- Bar
', subject)).to eq 'Check out:
- Foo
- Bar
'
end
it 'removes a without href' do
@@ -45,5 +37,13 @@ describe Sanitize::Config do
it 'keeps a with href' do
expect(Sanitize.fragment('Test', subject)).to eq 'Test'
end
+
+ it 'removes a with unparsable href' do
+ expect(Sanitize.fragment('Test', subject)).to eq 'Test'
+ end
+
+ it 'keeps a with supported scheme and no host' do
+ expect(Sanitize.fragment('Test', subject)).to eq 'Test'
+ end
end
end