独自機能の追加などで他の部分への影響が分かるようにCI周りの修正 (#1)

* Fix EmojiFormatter failure

* Add notification_emails.warning setting default value

* Fix list spec failure and add antennas for spec response

* Fix domain block spec failure to add kb custom response

* Fix SearchQueryTransformer spec failure

* Fix Account#matches_display_name spec failure

* Fix UpdateStatusService changes mentions spec failure

* Fix RuboCop Lint

* Ignore brakeman warning

* Fix CI failure for ignore brakeman warning

* Fix migration failure

* Fix README

* Fix migration CI failure

* Fix some spec failure

* Format code for RuboCop lint failure

* Fix ESlint failure

* Fix haml-lint failure

db/migrate/20230308061833_add_image_size_to_custom_emojis.rb

@@ -2,16 +2,20 @@
 
 class AddImageSizeToCustomEmojis < ActiveRecord::Migration[6.1]
   def change
-    change_table :custom_emojis, bulk: true do |t|
-      t.integer :image_width
-      t.integer :image_height
+    safety_assured do
+      change_table :custom_emojis, bulk: true do |t|
+        t.integer :image_width
+        t.integer :image_height
+      end
     end
   end
 
   def down
-    change_table :custom_emojis, bulk: true do |t|
-      t.remove :image_width
-      t.remove :image_height
+    safety_assured do
+      change_table :custom_emojis, bulk: true do |t|
+        t.remove :image_width
+        t.remove :image_height
+      end
     end
   end
 end

db/migrate/20230405121625_add_searchability_to_accounts.rb

@@ -2,6 +2,8 @@
 
 class AddSearchabilityToAccounts < ActiveRecord::Migration[6.1]
   def change
-    add_column :accounts, :searchability, :integer, null: false, default: 0
+    safety_assured do
+      add_column :accounts, :searchability, :integer, null: false, default: 0
+    end
   end
 end

db/migrate/20230410004651_add_emoji_reactions_count_to_status_stats.rb

@@ -2,6 +2,8 @@
 
 class AddEmojiReactionsCountToStatusStats < ActiveRecord::Migration[6.1]
   def change
-    add_column :status_stats, :emoji_reactions_count, :integer, null: false, default: 0
+    safety_assured do
+      add_column :status_stats, :emoji_reactions_count, :integer, null: false, default: 0
+    end
   end
 end

db/migrate/20230412005311_add_markdown_to_statuses.rb

@@ -2,6 +2,8 @@
 
 class AddMarkdownToStatuses < ActiveRecord::Migration[6.1]
   def change
-    add_column :statuses, :markdown, :boolean, default: false
+    safety_assured do
+      add_column :statuses, :markdown, :boolean, default: false
+    end
   end
 end

db/migrate/20230412073021_add_markdown_to_status_edits.rb

@@ -2,6 +2,8 @@
 
 class AddMarkdownToStatusEdits < ActiveRecord::Migration[6.1]
   def change
-    add_column :status_edits, :markdown, :boolean, default: false
+    safety_assured do
+      add_column :status_edits, :markdown, :boolean, default: false
+    end
   end
 end

db/migrate/20230414010523_add_emoji_reactions_count_per_account_to_status_stats.rb

@@ -2,6 +2,8 @@
 
 class AddEmojiReactionsCountPerAccountToStatusStats < ActiveRecord::Migration[6.1]
   def change
-    add_column :status_stats, :emoji_reaction_accounts_count, :integer, null: false, default: 0
+    safety_assured do
+      add_column :status_stats, :emoji_reaction_accounts_count, :integer, null: false, default: 0
+    end
   end
 end

db/migrate/20230426013738_add_excludes_to_antennas.rb

@@ -2,18 +2,22 @@
 
 class AddExcludesToAntennas < ActiveRecord::Migration[6.1]
   def change
-    change_table :antennas, bulk: true do |t|
-      t.jsonb :exclude_domains
-      t.jsonb :exclude_accounts
-      t.jsonb :exclude_tags
+    safety_assured do
+      change_table :antennas, bulk: true do |t|
+        t.jsonb :exclude_domains
+        t.jsonb :exclude_accounts
+        t.jsonb :exclude_tags
+      end
     end
   end
 
   def down
-    change_table :antennas, bulk: true do |t|
-      t.remove :exclude_domains
-      t.remove :exclude_accounts
-      t.remove :exclude_tags
+    safety_assured do
+      change_table :antennas, bulk: true do |t|
+        t.remove :exclude_domains
+        t.remove :exclude_accounts
+        t.remove :exclude_tags
+      end
     end
   end
 end

db/migrate/20230427072650_add_reject_sending_to_domain_blocks.rb

@@ -2,24 +2,28 @@
 
 class AddRejectSendingToDomainBlocks < ActiveRecord::Migration[6.1]
   def change
-    change_table :domain_blocks, bulk: true do |t|
-      t.boolean :reject_send_not_public_searchability, null: false, default: false
-      t.boolean :reject_send_unlisted_dissubscribable, null: false, default: false
-      t.boolean :reject_send_public_unlisted, null: false, default: false
-      t.boolean :reject_send_dissubscribable, null: false, default: false
-      t.boolean :reject_send_media, null: false, default: false
-      t.boolean :reject_send_sensitive, null: false, default: false
+    safety_assured do
+      change_table :domain_blocks, bulk: true do |t|
+        t.boolean :reject_send_not_public_searchability, null: false, default: false
+        t.boolean :reject_send_unlisted_dissubscribable, null: false, default: false
+        t.boolean :reject_send_public_unlisted, null: false, default: false
+        t.boolean :reject_send_dissubscribable, null: false, default: false
+        t.boolean :reject_send_media, null: false, default: false
+        t.boolean :reject_send_sensitive, null: false, default: false
+      end
     end
   end
 
   def down
-    change_table :domain_blocks, bulk: true do |t|
-      t.remove :reject_send_not_public_searchability
-      t.remove :reject_send_unlisted_dissubscribable
-      t.remove :reject_send_public_unlisted
-      t.remove :reject_send_dissubscribable
-      t.remove :reject_send_media
-      t.remove :reject_send_sensitive
+    safety_assured do
+      change_table :domain_blocks, bulk: true do |t|
+        t.remove :reject_send_not_public_searchability
+        t.remove :reject_send_unlisted_dissubscribable
+        t.remove :reject_send_public_unlisted
+        t.remove :reject_send_dissubscribable
+        t.remove :reject_send_media
+        t.remove :reject_send_sensitive
+      end
     end
   end
 end

db/migrate/20230427122753_add_some_to_domain_blocks.rb

@@ -2,18 +2,22 @@
 
 class AddSomeToDomainBlocks < ActiveRecord::Migration[6.1]
   def change
-    change_table :domain_blocks, bulk: true do |t|
-      t.boolean :reject_hashtag, null: false, default: false
-      t.boolean :reject_straight_follow, null: false, default: false
-      t.boolean :reject_new_follow, null: false, default: false
+    safety_assured do
+      change_table :domain_blocks, bulk: true do |t|
+        t.boolean :reject_hashtag, null: false, default: false
+        t.boolean :reject_straight_follow, null: false, default: false
+        t.boolean :reject_new_follow, null: false, default: false
+      end
     end
   end
 
   def down
-    change_table :domain_blocks, bulk: true do |t|
-      t.remove :reject_hashtag
-      t.remove :reject_straight_follow
-      t.remove :reject_new_follow
+    safety_assured do
+      change_table :domain_blocks, bulk: true do |t|
+        t.remove :reject_hashtag
+        t.remove :reject_straight_follow
+        t.remove :reject_new_follow
+      end
     end
   end
 end

db/migrate/20230427233749_add_hidden_to_domain_blocks.rb

@@ -2,16 +2,20 @@
 
 class AddHiddenToDomainBlocks < ActiveRecord::Migration[6.1]
   def change
-    change_table :domain_blocks, bulk: true do |t|
-      t.boolean :hidden, null: false, default: false
-      t.boolean :hidden_anonymous, null: false, default: false
+    safety_assured do
+      change_table :domain_blocks, bulk: true do |t|
+        t.boolean :hidden, null: false, default: false
+        t.boolean :hidden_anonymous, null: false, default: false
+      end
     end
   end
 
   def down
-    change_table :domain_blocks, bulk: true do |t|
-      t.remove :hidden
-      t.remove :hidden_anonymous
+    safety_assured do
+      change_table :domain_blocks, bulk: true do |t|
+        t.remove :hidden
+        t.remove :hidden_anonymous
+      end
     end
   end
 end

db/migrate/20230428111230_add_emoji_reaction_streaming_to_accounts.rb

@@ -2,6 +2,8 @@
 
 class AddEmojiReactionStreamingToAccounts < ActiveRecord::Migration[6.1]
   def change
-    add_column :accounts, :stop_emoji_reaction_streaming, :boolean, default: false
+    safety_assured do
+      add_column :accounts, :stop_emoji_reaction_streaming, :boolean, default: false
+    end
   end
 end

db/migrate/20230430110057_add_reject_invalid_subscription_to_domain_blocks.rb

@@ -1,10 +1,23 @@
 # frozen_string_literal: true
 
 class AddRejectInvalidSubscriptionToDomainBlocks < ActiveRecord::Migration[6.1]
-  def change
+  def up
     safety_assured do
-      remove_column :domain_blocks, :reject_send_unlisted_dissubscribable, :boolean, null: false, default: false
+      remove_column :domain_blocks, :reject_send_unlisted_dissubscribable
+
+      change_table :domain_blocks do |t|
+        t.boolean :detect_invalid_subscription, null: false, default: false
+      end
+    end
+  end
+
+  def down
+    safety_assured do
+      remove_column :domain_blocks, :detect_invalid_subscription
+
+      change_table :domain_blocks do |t|
+        t.boolean :reject_send_unlisted_dissubscribable, null: false, default: false
+      end
     end
-    add_column :domain_blocks, :detect_invalid_subscription, :boolean, null: false, default: false
   end
 end

db/migrate/20230512122757_add_reject_reply_exclude_followers_to_domain_blocks.rb

@@ -2,6 +2,10 @@
 
 class AddRejectReplyExcludeFollowersToDomainBlocks < ActiveRecord::Migration[6.1]
   def change
-    add_column :domain_blocks, :reject_reply_exclude_followers, :boolean, null: false, default: false
+    safety_assured do
+      change_table :domain_blocks do |t|
+        t.boolean :reject_reply_exclude_followers, null: false, default: false
+      end
+    end
   end
 end

db/migrate/20230522082252_add_is_sensitive_to_custom_emojis.rb

@@ -2,6 +2,10 @@
 
 class AddIsSensitiveToCustomEmojis < ActiveRecord::Migration[6.1]
   def change
-    add_column :custom_emojis, :is_sensitive, :boolean, null: false, default: false
+    safety_assured do
+      change_table :custom_emojis do |t|
+        t.boolean :is_sensitive, null: false, default: false
+      end
+    end
   end
 end