Add support for ingesting quote policies (#34479)

This commit is contained in:
Claire 2025-04-28 10:48:27 +02:00 committed by GitHub
parent 1a1f3f037d
commit 9ed6a14d45
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 181 additions and 4 deletions

View file

@ -7,10 +7,11 @@ RSpec.describe ActivityPub::Parser::StatusParser do
let(:sender) { Fabricate(:account, followers_url: 'http://example.com/followers', domain: 'example.com', uri: 'https://example.com/actor') }
let(:follower) { Fabricate(:account, username: 'bob') }
let(:context) { 'https://www.w3.org/ns/activitystreams' }
let(:json) do
{
'@context': 'https://www.w3.org/ns/activitystreams',
'@context': context,
id: [ActivityPub::TagManager.instance.uri_for(sender), '#foo'].join,
type: 'Create',
actor: ActivityPub::TagManager.instance.uri_for(sender),
@ -47,4 +48,116 @@ RSpec.describe ActivityPub::Parser::StatusParser do
language: :en
)
end
describe '#quote_policy' do
subject do
described_class
.new(
json,
actor_uri: ActivityPub::TagManager.instance.uri_for(sender),
followers_collection: sender.followers_url
).quote_policy
end
let(:context) do
[
'https://www.w3.org/ns/activitystreams',
{
gts: 'https://gotosocial.org/ns#',
interactionPolicy: {
'@id': 'gts:interactionPolicy',
'@type': '@id',
},
canQuote: {
'@id': 'gts:canQuote',
'@type': '@id',
},
automaticApproval: {
'@id': 'gts:automaticApproval',
'@type': '@id',
},
manualApproval: {
'@id': 'gts:manualApproval',
'@type': '@id',
},
},
]
end
context 'when nobody is allowed to quote' do
let(:object_json) do
{
id: [ActivityPub::TagManager.instance.uri_for(sender), 'post1'].join('/'),
type: 'Note',
to: [
'https://www.w3.org/ns/activitystreams#Public',
ActivityPub::TagManager.instance.uri_for(follower),
],
interactionPolicy: {
canQuote: {
automaticApproval: ActivityPub::TagManager.instance.uri_for(sender),
},
},
content: 'bleh',
published: 1.hour.ago.utc.iso8601,
updated: 1.hour.ago.utc.iso8601,
}
end
it 'returns a policy not allowing anyone to quote' do
expect(subject).to eq 0
end
end
context 'when everybody is allowed to quote' do
let(:object_json) do
{
id: [ActivityPub::TagManager.instance.uri_for(sender), 'post1'].join('/'),
type: 'Note',
to: [
'https://www.w3.org/ns/activitystreams#Public',
ActivityPub::TagManager.instance.uri_for(follower),
],
interactionPolicy: {
canQuote: {
automaticApproval: 'https://www.w3.org/ns/activitystreams#Public',
},
},
content: 'bleh',
published: 1.hour.ago.utc.iso8601,
updated: 1.hour.ago.utc.iso8601,
}
end
it 'returns a policy not allowing anyone to quote' do
expect(subject).to eq(Status::QUOTE_APPROVAL_POLICY_FLAGS[:public] << 16)
end
end
context 'when everybody is allowed to quote but only followers are automatically approved' do
let(:object_json) do
{
id: [ActivityPub::TagManager.instance.uri_for(sender), 'post1'].join('/'),
type: 'Note',
to: [
'https://www.w3.org/ns/activitystreams#Public',
ActivityPub::TagManager.instance.uri_for(follower),
],
interactionPolicy: {
canQuote: {
automaticApproval: sender.followers_url,
manualApproval: 'https://www.w3.org/ns/activitystreams#Public',
},
},
content: 'bleh',
published: 1.hour.ago.utc.iso8601,
updated: 1.hour.ago.utc.iso8601,
}
end
it 'returns a policy allowing everyone including followers' do
expect(subject).to eq Status::QUOTE_APPROVAL_POLICY_FLAGS[:public] | (Status::QUOTE_APPROVAL_POLICY_FLAGS[:followers] << 16)
end
end
end
end