Add support for FASP data sharing (#34415)

This commit is contained in:
David Roetzel 2025-05-16 14:24:02 +02:00 committed by GitHub
parent 3ea1f074ab
commit a5a2c6dc7e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
38 changed files with 1140 additions and 1 deletions

View file

@ -0,0 +1,83 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Account::FaspConcern, feature: :fasp do
describe '#create' do
let(:discoverable_attributes) do
Fabricate.attributes_for(:account).except('user_id')
end
let(:undiscoverable_attributes) do
discoverable_attributes.merge('discoverable' => false)
end
context 'when account is discoverable' do
it 'queues a job to notify provider' do
Account.create(discoverable_attributes)
expect(Fasp::AnnounceAccountLifecycleEventWorker).to have_enqueued_sidekiq_job
end
end
context 'when account is not discoverable' do
it 'does not queue a job' do
Account.create(undiscoverable_attributes)
expect(Fasp::AnnounceAccountLifecycleEventWorker).to_not have_enqueued_sidekiq_job
end
end
end
describe '#update' do
before do
# Create account and clear sidekiq queue so we only catch
# jobs queued as part of the update
account
Sidekiq::Worker.clear_all
end
context 'when account is discoverable' do
let(:account) { Fabricate(:account, domain: 'example.com') }
it 'queues a job to notify provider' do
expect { account.touch }.to enqueue_sidekiq_job(Fasp::AnnounceAccountLifecycleEventWorker)
end
end
context 'when account was discoverable before' do
let(:account) { Fabricate(:account, domain: 'example.com') }
it 'queues a job to notify provider' do
expect do
account.update(discoverable: false)
end.to enqueue_sidekiq_job(Fasp::AnnounceAccountLifecycleEventWorker)
end
end
context 'when account has not been discoverable' do
let(:account) { Fabricate(:account, domain: 'example.com', discoverable: false) }
it 'does not queue a job' do
expect { account.touch }.to_not enqueue_sidekiq_job(Fasp::AnnounceAccountLifecycleEventWorker)
end
end
end
describe '#destroy' do
context 'when account is discoverable' do
let(:account) { Fabricate(:account, domain: 'example.com') }
it 'queues a job to notify provider' do
expect { account.destroy }.to enqueue_sidekiq_job(Fasp::AnnounceAccountLifecycleEventWorker)
end
end
context 'when account is not discoverable' do
let(:account) { Fabricate(:account, domain: 'example.com', discoverable: false) }
it 'does not queue a job' do
expect { account.destroy }.to_not enqueue_sidekiq_job(Fasp::AnnounceAccountLifecycleEventWorker)
end
end
end
end

View file

@ -0,0 +1,11 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Favourite::FaspConcern, feature: :fasp do
describe '#create' do
it 'queues a job to notify provider' do
expect { Fabricate(:favourite) }.to enqueue_sidekiq_job(Fasp::AnnounceTrendWorker)
end
end
end

View file

@ -0,0 +1,123 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Status::FaspConcern, feature: :fasp do
describe '#create' do
context 'when account is indexable' do
let(:account) { Fabricate(:account, domain: 'example.com') }
context 'when status is public' do
it 'queues a job to notify provider of new status' do
expect do
Fabricate(:status, account:)
end.to enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
context 'when status is not public' do
it 'does not queue a job' do
expect do
Fabricate(:status, account:, visibility: :unlisted)
end.to_not enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
context 'when status is in reply to another' do
it 'queues a job to notify provider of possible trend' do
parent = Fabricate(:status)
expect do
Fabricate(:status, account:, thread: parent)
end.to enqueue_sidekiq_job(Fasp::AnnounceTrendWorker)
end
end
context 'when status is a reblog of another' do
it 'queues a job to notify provider of possible trend' do
original = Fabricate(:status, account:)
expect do
Fabricate(:status, account:, reblog: original)
end.to enqueue_sidekiq_job(Fasp::AnnounceTrendWorker)
end
end
end
context 'when account is not indexable' do
let(:account) { Fabricate(:account, indexable: false) }
it 'does not queue a job' do
expect do
Fabricate(:status, account:)
end.to_not enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
end
describe '#update' do
before do
# Create status and clear sidekiq queues to only catch
# jobs queued due to the update
status
Sidekiq::Worker.clear_all
end
context 'when account is indexable' do
let(:account) { Fabricate(:account, domain: 'example.com') }
let(:status) { Fabricate(:status, account:, visibility:) }
context 'when status is public' do
let(:visibility) { :public }
it 'queues a job to notify provider' do
expect { status.touch }.to enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
context 'when status has not been public' do
let(:visibility) { :unlisted }
it 'does not queue a job' do
expect do
status.touch
end.to_not enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
end
context 'when account is not indexable' do
let(:account) { Fabricate(:account, domain: 'example.com', indexable: false) }
let(:status) { Fabricate(:status, account:) }
it 'does not queue a job' do
expect { status.touch }.to_not enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
end
describe '#destroy' do
let(:status) { Fabricate(:status, account:) }
before do
# Create status and clear sidekiq queues to only catch
# jobs queued due to the update
status
Sidekiq::Worker.clear_all
end
context 'when account is indexable' do
let(:account) { Fabricate(:account, domain: 'example.com') }
it 'queues a job to notify provider' do
expect { status.destroy }.to enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
context 'when account is not indexable' do
let(:account) { Fabricate(:account, domain: 'example.com', indexable: false) }
it 'does not queue a job' do
expect { status.destroy }.to_not enqueue_sidekiq_job(Fasp::AnnounceContentLifecycleEventWorker)
end
end
end
end