Move server rule creation form to its own page (#34637)

app/controllers/admin/rules_controller.rb

@@ -2,13 +2,17 @@
 
 module Admin
   class RulesController < BaseController
-    before_action :set_rule, except: [:index, :create]
+    before_action :set_rule, except: [:index, :new, :create]
 
     def index
       authorize :rule, :index?
 
       @rules = Rule.ordered
-      @rule  = Rule.new
+    end
+
+    def new
+      authorize :rule, :create?
+      @rule = Rule.new
     end
 
     def edit
@@ -24,7 +28,7 @@ module Admin
         redirect_to admin_rules_path
       else
         @rules = Rule.ordered
-        render :index
+        render :new
       end
     end
 

app/views/admin/rules/index.html.haml

@@ -1,21 +1,12 @@
 - content_for :page_title do
   = t('admin.rules.title')
 
-%p= t('admin.rules.description_html')
+- content_for :heading_actions do
+  - if can? :create, :rule
+    = link_to t('admin.rules.add_new'), new_admin_rule_path, class: 'button'
 
 %hr.spacer/
 
-- if can? :create, :rule
-  = simple_form_for @rule, url: admin_rules_path do |form|
-    = render 'shared/error_messages', object: @rule
-
-    = render form
-
-    .actions
-      = form.button :button, t('admin.rules.add_new'), type: :submit
-
-  %hr.spacer/
-
 - if @rules.empty?
   .muted-hint.center-text
     = t 'admin.rules.empty'

app/views/admin/rules/new.html.haml

@@ -0,0 +1,14 @@
+- content_for :page_title do
+  = t('admin.rules.add_new')
+
+%p= t('admin.rules.description_html')
+
+%hr.spacer/
+
+= simple_form_for @rule, url: admin_rules_path do |form|
+  = render 'shared/error_messages', object: @rule
+
+  = render form
+
+  .actions
+    = form.button :button, t('admin.rules.add_new'), type: :submit

config/routes/admin.rb

@@ -93,7 +93,7 @@ namespace :admin do
     end
   end
 
-  resources :rules, only: [:index, :create, :edit, :update, :destroy]
+  resources :rules, only: [:index, :new, :create, :edit, :update, :destroy]
 
   resources :webhooks do
     member do

spec/system/admin/rules_spec.rb

@@ -26,6 +26,8 @@ RSpec.describe 'Admin Rules' do
       it 'creates new record with valid attributes' do
         visit admin_rules_path
 
+        click_on I18n.t('admin.rules.add_new')
+
         # Invalid submission
         fill_in 'rule_text', with: ''
         expect { submit_form }