Fix: LD Signaturesで署名された投稿の検索許可(検索範囲)が改竄できる問題

This commit is contained in:
KMY 2024-09-10 06:51:26 +09:00
parent ec9644b9a6
commit b6278e0d39
6 changed files with 39 additions and 13 deletions

View file

@ -507,15 +507,15 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
end
def searchability_from_audience
if audience_searchable_by.nil?
nil
elsif audience_searchable_by.any? { |uri| ActivityPub::TagManager.instance.public_collection?(uri) }
return nil if audience_searchable_by.blank?
if audience_searchable_by.any? { |uri| ActivityPub::TagManager.instance.public_collection?(uri) }
:public
elsif audience_searchable_by.include?('kmyblue:Limited') || audience_searchable_by.include?('as:Limited')
:limited
elsif audience_searchable_by.include?(@account.followers_url)
:private
else
elsif audience_searchable_by.include?(@account.uri) || audience_searchable_by.include?(@account.url)
:direct
end
end

View file

@ -237,12 +237,10 @@ class ActivityPub::TagManager
[COLLECTIONS[:public]]
when 'private'
[account_followers_url(status.account)]
when 'direct'
status.conversation_id.present? ? [uri_for(status.conversation)] : []
when 'limited'
['as:Limited', 'kmyblue:Limited']
else
[]
status.conversation_id.present? ? [uri_for(status.conversation), account_url(status.account)] : [account_url(status.account)]
end
searchable_by.concat(mentions_uris(status)).compact
@ -257,7 +255,7 @@ class ActivityPub::TagManager
when 'limited'
['as:Limited', 'kmyblue:Limited']
else
[]
[account_url(account)]
end
end