Fix: LD Signaturesで署名された投稿の検索許可(検索範囲)が改竄できる問題

This commit is contained in:
KMY 2024-09-10 06:51:26 +09:00
parent ec9644b9a6
commit b6278e0d39
6 changed files with 39 additions and 13 deletions

View file

@ -5,9 +5,9 @@ require 'rails_helper'
describe ActivityPub::NoteSerializer do
subject { JSON.parse(@serialization.to_json) }
let!(:account) { Fabricate(:account) }
let!(:account) { Fabricate(:account, searchability: :public) }
let!(:other) { Fabricate(:account) }
let!(:parent) { Fabricate(:status, account: account, visibility: :public, language: 'zh-TW') }
let!(:parent) { Fabricate(:status, account: account, visibility: :public, searchability: searchability, language: 'zh-TW') }
let!(:reply_by_account_first) { Fabricate(:status, account: account, thread: parent, visibility: :public) }
let!(:reply_by_account_next) { Fabricate(:status, account: account, thread: parent, visibility: :public) }
let!(:reply_by_other_first) { Fabricate(:status, account: other, thread: parent, visibility: :public) }
@ -16,6 +16,7 @@ describe ActivityPub::NoteSerializer do
let!(:referred) { nil }
let!(:referred2) { nil }
let(:convert_to_quote) { false }
let(:searchability) { :public }
before(:each) do
parent.references << referred if referred.present?
@ -55,6 +56,14 @@ describe ActivityPub::NoteSerializer do
expect(subject['replies']['first']['items']).to_not include(reply_by_account_visibility_direct.uri)
end
context 'when direct searchability' do
let(:searchability) { :direct }
it 'send as direct searchability' do
expect(subject['searchableBy']).to include "https://cb6e6126.ngrok.io/users/#{account.username}"
end
end
context 'when has quote but no_convert setting' do
let(:referred) { Fabricate(:status) }