From ca560c10958d3ad96736c974c778380c2adacef2 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Wed, 15 May 2024 09:57:13 -0400
Subject: [PATCH] Disable `Style/RedundantFetchBlock` cop (#30207)
---
.rubocop.yml | 5 +++++
.rubocop_todo.yml | 10 ----------
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/.rubocop.yml b/.rubocop.yml
index 542e90b5e3..cbc0afd281 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -211,6 +211,11 @@ Style/PercentLiteralDelimiters:
Style/RedundantBegin:
Enabled: false
+# Reason: Prevailing style choice
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfetchblock
+Style/RedundantFetchBlock:
+ Enabled: false
+
# Reason: Overridden to reduce implicit StandardError rescues
# https://docs.rubocop.org/rubocop/cops_style.html#stylerescuestandarderror
Style/RescueStandardError:
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index b47d682f3e..064f622085 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -169,16 +169,6 @@ Style/RedundantConstantBase:
- 'config/environments/production.rb'
- 'config/initializers/sidekiq.rb'
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SafeForConstants.
-Style/RedundantFetchBlock:
- Exclude:
- - 'config/initializers/1_hosts.rb'
- - 'config/initializers/chewy.rb'
- - 'config/initializers/devise.rb'
- - 'config/initializers/paperclip.rb'
- - 'config/puma.rb'
-
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
# AllowedMethods: present?, blank?, presence, try, try!