Re-add follow recommendations API (#7918)

* Re-add follow recommendations API

    GET /api/v1/suggestions

Removed in 8efa081f21 due to Neo4J
dependency. The algorithm uses triadic closures, takes into account
suspensions, blocks, mutes, domain blocks, excludes locked and moved
accounts, and prefers more recently updated accounts.

* Track interactions with people you don't follow

Replying to, favouriting and reblogging someone you're not following
will make them show up in follow recommendations. The interactions
have different weights:

- Replying is 1
- Favouriting is 10 (decidedly positive interaction, but private)
- Reblogging is 20

Following them, muting or blocking will remove them from the list,
obviously.

* Remove triadic closures, ensure potential friendships are trimmed
This commit is contained in:
Eugen Rochko 2018-07-03 01:47:56 +02:00 committed by GitHub
parent ac82c9380f
commit da8fe8079e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 131 additions and 99 deletions

View file

@ -454,77 +454,6 @@ RSpec.describe Account, type: :model do
end
end
describe '.triadic_closures' do
let!(:me) { Fabricate(:account) }
let!(:friend) { Fabricate(:account) }
let!(:friends_friend) { Fabricate(:account) }
let!(:both_follow) { Fabricate(:account) }
before do
me.follow!(friend)
friend.follow!(friends_friend)
me.follow!(both_follow)
friend.follow!(both_follow)
end
it 'finds accounts you dont follow which are followed by accounts you do follow' do
expect(described_class.triadic_closures(me)).to eq [friends_friend]
end
it 'limits by 5 with offset 0 by defualt' do
first_degree = 6.times.map { Fabricate(:account) }
matches = 5.times.map { Fabricate(:account) }
first_degree.each { |account| me.follow!(account) }
matches.each do |match|
first_degree.each { |account| account.follow!(match) }
first_degree.shift
end
expect(described_class.triadic_closures(me)).to eq matches
end
it 'accepts arbitrary limits' do
another_friend = Fabricate(:account)
higher_friends_friend = Fabricate(:account)
me.follow!(another_friend)
friend.follow!(higher_friends_friend)
another_friend.follow!(higher_friends_friend)
expect(described_class.triadic_closures(me, limit: 1)).to eq [higher_friends_friend]
end
it 'acceps arbitrary offset' do
another_friend = Fabricate(:account)
higher_friends_friend = Fabricate(:account)
me.follow!(another_friend)
friend.follow!(higher_friends_friend)
another_friend.follow!(higher_friends_friend)
expect(described_class.triadic_closures(me, offset: 1)).to eq [friends_friend]
end
context 'when you block account' do
before do
me.block!(friends_friend)
end
it 'rejects blocked accounts' do
expect(described_class.triadic_closures(me)).to be_empty
end
end
context 'when you mute account' do
before do
me.mute!(friends_friend)
end
it 'rejects muted accounts' do
expect(described_class.triadic_closures(me)).to be_empty
end
end
end
describe '#statuses_count' do
subject { Fabricate(:account) }