From dd51fae42ff22bb633ec26c344285e3c7db334d8 Mon Sep 17 00:00:00 2001 From: KMY Date: Thu, 21 Sep 2023 16:23:37 +0900 Subject: [PATCH] Remove unsafed api emoji_reactions slim --- ..._reactioned_by_accounts_slim_controller.rb | 31 ------------------- ...oji_reactions_grouped_by_account_object.rb | 16 ---------- ...oji_reacted_by_slim_reaction_serializer.rb | 27 ---------------- .../rest/emoji_reacted_by_slim_serializer.rb | 20 ------------ config/routes/api.rb | 1 - 5 files changed, 95 deletions(-) delete mode 100644 app/controllers/api/v1/statuses/emoji_reactioned_by_accounts_slim_controller.rb delete mode 100644 app/models/status_emoji_reactions_grouped_by_account_object.rb delete mode 100644 app/serializers/rest/emoji_reacted_by_slim_reaction_serializer.rb delete mode 100644 app/serializers/rest/emoji_reacted_by_slim_serializer.rb diff --git a/app/controllers/api/v1/statuses/emoji_reactioned_by_accounts_slim_controller.rb b/app/controllers/api/v1/statuses/emoji_reactioned_by_accounts_slim_controller.rb deleted file mode 100644 index 91ced4340c..0000000000 --- a/app/controllers/api/v1/statuses/emoji_reactioned_by_accounts_slim_controller.rb +++ /dev/null @@ -1,31 +0,0 @@ -# frozen_string_literal: true - -class Api::V1::Statuses::EmojiReactionedByAccountsSlimController < Api::BaseController - include Authorization - - before_action -> { authorize_if_got_token! :read, :'read:accounts' } - before_action :set_status - - def index - @accounts = load_emoji_reactions - - # TODO: for serialize hash object - # render json: @accounts, each_serializer: REST::EmojiReactedBySlimSerializer - - # Hide WIP api for hide account secret - not_found - end - - private - - def load_emoji_reactions - @status.generate_emoji_reactions_grouped_by_account - end - - def set_status - @status = Status.find(params[:status_id]) - authorize @status, :show? - rescue Mastodon::NotPermittedError - not_found - end -end diff --git a/app/models/status_emoji_reactions_grouped_by_account_object.rb b/app/models/status_emoji_reactions_grouped_by_account_object.rb deleted file mode 100644 index 8c108fddde..0000000000 --- a/app/models/status_emoji_reactions_grouped_by_account_object.rb +++ /dev/null @@ -1,16 +0,0 @@ -# frozen_string_literal: true - -class StatusEmojiReactionsGroupedByAccountObject - def initialize(account, emoji_reactions) - @account = account - @emoji_reactions = emoji_reactions - end - - def read_attribute_for_serialization(_) - REST::EmojiReactedBySlimSerializer - end - - def model_name - 'EmojiReaction' - end -end diff --git a/app/serializers/rest/emoji_reacted_by_slim_reaction_serializer.rb b/app/serializers/rest/emoji_reacted_by_slim_reaction_serializer.rb deleted file mode 100644 index 234218f2e0..0000000000 --- a/app/serializers/rest/emoji_reacted_by_slim_reaction_serializer.rb +++ /dev/null @@ -1,27 +0,0 @@ -# frozen_string_literal: true - -class REST::EmojiReactedBySlimReactionSerializer < ActiveModel::Serializer - include RoutingHelper - - attributes :name - - attribute :url, if: :custom_emoji? - attribute :static_url, if: :custom_emoji? - attribute :domain, if: :custom_emoji? - - def url - full_asset_url(object.custom_emoji.image.url) - end - - def static_url - full_asset_url(object.custom_emoji.image.url(:static)) - end - - def domain - object.custom_emoji.domain - end - - def custom_emoji? - object.custom_emoji.present? - end -end diff --git a/app/serializers/rest/emoji_reacted_by_slim_serializer.rb b/app/serializers/rest/emoji_reacted_by_slim_serializer.rb deleted file mode 100644 index 013a0ce84a..0000000000 --- a/app/serializers/rest/emoji_reacted_by_slim_serializer.rb +++ /dev/null @@ -1,20 +0,0 @@ -# frozen_string_literal: true - -class REST::EmojiReactedBySlimSerializer < ActiveModel::Serializer - belongs_to :account, serializer: REST::AccountSerializer - has_many :emoji_reactions, serializer: REST::EmojiReactedBySlimReactionSerializer - - def attributes - { account => emoji_reactions } - end - - private - - def account - object.first - end - - def emoji_reactions - object.last - end -end diff --git a/config/routes/api.rb b/config/routes/api.rb index 8f8b7f5f81..9bf466ddab 100644 --- a/config/routes/api.rb +++ b/config/routes/api.rb @@ -11,7 +11,6 @@ namespace :api, format: false do resources :reblogged_by, controller: :reblogged_by_accounts, only: :index resources :favourited_by, controller: :favourited_by_accounts, only: :index resources :emoji_reactioned_by, controller: :emoji_reactioned_by_accounts, only: :index - resources :emoji_reactioned_by_slim, controller: :emoji_reactioned_by_accounts_slim, only: :index resources :referred_by, controller: :referred_by_statuses, only: :index resources :bookmark_categories, only: :index resource :reblog, only: :create