Add: #586 保留中のリモートアカウントからのフォローが飛んできた場合に記録する (#590)

* Add: #586 保留中のリモートアカウントからのフォローが飛んできた場合に記録する

* 本家に戻す処理を修正

* Fix test

* Fix worker link

* Fix test

* リモートアカウント拒否時に既存のリクエストを削除
This commit is contained in:
KMY(雪あすか) 2024-02-18 10:48:48 +09:00 committed by GitHub
parent 1b3c0e3fb7
commit dfc9f35d71
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
15 changed files with 262 additions and 31 deletions

View file

@ -100,6 +100,10 @@ RSpec.describe ActivityPub::Activity::Follow do
expect(sender.requested?(recipient)).to be true
expect(sender.follow_requests.find_by(target_account: recipient).uri).to eq 'foo'
end
it 'does not create pending request' do
expect(sender.pending_follow_requests.find_by(target_account: recipient)).to be_nil
end
end
context 'when unlocked account but locked from bot' do
@ -169,6 +173,49 @@ RSpec.describe ActivityPub::Activity::Follow do
end
end
context 'when remote pending account follows unlocked account' do
before do
sender.update(suspended_at: Time.now.utc, suspension_origin: :local, remote_pending: true)
allow(LocalNotificationWorker).to receive(:perform_async).and_return(nil)
subject.perform
end
it 'does not create a follow from sender to recipient' do
expect(sender.following?(recipient)).to be false
end
it 'does not notify' do
expect(LocalNotificationWorker).to_not have_received(:perform_async)
end
it 'creates a follow request' do
expect(sender.requested?(recipient)).to be false
follow_request = sender.pending_follow_requests.find_by(target_account: recipient)
expect(follow_request).to_not be_nil
expect(follow_request.uri).to eq 'foo'
end
end
context 'when remote pending account follows unlocked account but has already existing request' do
before do
sender.update(suspended_at: Time.now.utc, suspension_origin: :local, remote_pending: true)
Fabricate(:pending_follow_request, account: sender, target_account: recipient, uri: 'old')
subject.perform
end
it 'does not create a follow from sender to recipient' do
expect(sender.following?(recipient)).to be false
expect(sender.requested?(recipient)).to be false
end
it 'changes follow request uri' do
follow_request = sender.pending_follow_requests.find_by(target_account: recipient)
expect(follow_request).to_not be_nil
expect(follow_request.uri).to eq 'foo'
end
end
context 'when domain block reject_straight_follow' do
before do
Fabricate(:domain_block, domain: 'example.com', reject_straight_follow: true)