Add test for sending unlisted post to misskey

spec/lib/status_reach_finder_spec.rb

@@ -12,6 +12,59 @@ describe StatusReachFinder do
       let(:alice) { Fabricate(:account, username: 'alice') }
       let(:status) { Fabricate(:status, account: alice, thread: parent_status, visibility: visibility) }
 
+      context 'with a simple case' do
+        let(:bob) { Fabricate(:account, username: 'bob', domain: 'foo.bar', protocol: :activitypub, inbox_url: 'https://foo.bar/inbox') }
+
+        context 'with follower' do
+          before do
+            bob.follow!(alice)
+          end
+
+          it 'send status' do
+            expect(subject.inboxes).to include 'https://foo.bar/inbox'
+          end
+        end
+
+        context 'with non-follower' do
+          it 'send status' do
+            expect(subject.inboxes).to_not include 'https://foo.bar/inbox'
+          end
+        end
+      end
+
+      context 'when misskey case with unlisted post' do
+        let(:bob) { Fabricate(:account, username: 'bob', domain: 'foo.bar', protocol: :activitypub, inbox_url: 'https://foo.bar/inbox') }
+        let(:sender_software) { 'mastodon' }
+        let(:visibility) { :unlisted }
+
+        before do
+          Fabricate(:instance_info, domain: 'foo.bar', software: sender_software)
+          bob.follow!(alice)
+        end
+
+        context 'when mastodon' do
+          it 'send status' do
+            expect(subject.inboxes).to include 'https://foo.bar/inbox'
+            expect(subject.inboxes_for_misskey).to_not include 'https://foo.bar/inbox'
+          end
+        end
+
+        context 'when misskey' do
+          let(:sender_software) { 'misskey' }
+
+          it 'send status without setting' do
+            expect(subject.inboxes).to include 'https://foo.bar/inbox'
+            expect(subject.inboxes_for_misskey).to_not include 'https://foo.bar/inbox'
+          end
+
+          it 'send status with setting' do
+            alice.user.settings.update(reject_unlisted_subscription: 'true')
+            expect(subject.inboxes).to_not include 'https://foo.bar/inbox'
+            expect(subject.inboxes_for_misskey).to include 'https://foo.bar/inbox'
+          end
+        end
+      end
+
       context 'when it contains mentions of remote accounts' do
         let(:bob) { Fabricate(:account, username: 'bob', domain: 'foo.bar', protocol: :activitypub, inbox_url: 'https://foo.bar/inbox') }
 

spec/serializers/activitypub/note_for_misskey_serializer_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe ActivityPub::NoteForMisskeySerializer do
+  subject { JSON.parse(serialization.to_json) }
+
+  let(:serialization) { ActiveModelSerializers::SerializableResource.new(parent, serializer: described_class, adapter: ActivityPub::Adapter) }
+  let!(:account) { Fabricate(:account) }
+  let!(:other) { Fabricate(:account) }
+  let!(:parent) { Fabricate(:status, account: account, visibility: :unlisted) }
+  let!(:reply_by_account_first) { Fabricate(:status, account: account, thread: parent, visibility: :public) }
+  let!(:reply_by_account_next) { Fabricate(:status, account: account, thread: parent, visibility: :public) }
+  let!(:reply_by_other_first) { Fabricate(:status, account: other, thread: parent, visibility: :public) }
+  let!(:reply_by_account_third) { Fabricate(:status, account: account, thread: parent, visibility: :public) }
+  let!(:reply_by_account_visibility_direct) { Fabricate(:status, account: account, thread: parent, visibility: :direct) }
+
+  before do
+    account.user.settings.update(reject_unlisted_subscription: 'true')
+  end
+
+  it 'has a Note type' do
+    expect(subject['type']).to eql('Note')
+  end
+
+  it 'has a replies collection' do
+    expect(subject['replies']['type']).to eql('Collection')
+  end
+
+  it 'has a replies collection with a first Page' do
+    expect(subject['replies']['first']['type']).to eql('CollectionPage')
+  end
+
+  it 'includes public self-replies in its replies collection' do
+    expect(subject['replies']['first']['items']).to include(reply_by_account_first.uri, reply_by_account_next.uri, reply_by_account_third.uri)
+  end
+
+  it 'does not include replies from others in its replies collection' do
+    expect(subject['replies']['first']['items']).to_not include(reply_by_other_first.uri)
+  end
+
+  it 'does not include replies with direct visibility in its replies collection' do
+    expect(subject['replies']['first']['items']).to_not include(reply_by_account_visibility_direct.uri)
+  end
+
+  it 'has private visibility' do
+    expect(subject['to']).to_not include('https://www.w3.org/ns/activitystreams#Public')
+    expect(subject['to'].any? { |to| to.end_with?("#{account.username}/followers") }).to be true
+    expect(subject['cc']).to_not include('https://www.w3.org/ns/activitystreams#Public')
+  end
+end