iVPS/glitch-bird
1
0
Fork 0
forked from gitea/glitch-bird
Code Pull requests Activity

Rescue uncaught RecordInvalid errors

Browse source 
These occur when an account tries to react with disabled custom emojis.
In both `EmojiReact` and `Like? activities, the activity is discarded.

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
This commit is contained in:
Plastikmensch 2023-05-14 23:53:57 +02:00 committed by Jeremy Kescher
parent 051bb17de8
commit 239170830e
No known key found for this signature in database
GPG key ID: 80A419A7A613DFA4
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/lib/activitypub/activity/emoji_react.rb
View file

@ -22,5 +22,7 @@ class ActivityPub::Activity::EmojiReact < ActivityPub::Activity
reaction = original_status.status_reactions.create!(account: @account, name: name, custom_emoji: custom_emoji)
LocalNotificationWorker.perform_async(original_status.account_id, reaction.id, 'StatusReaction', 'reaction')
rescue ActiveRecord::RecordInvalid
nil
end
end

3
app/lib/activitypub/activity/like.rb
View file

@ -34,5 +34,8 @@ class ActivityPub::Activity::Like < ActivityPub::Activity
reaction = original_status.status_reactions.create!(account: @account, name: name, custom_emoji: custom_emoji)
LocalNotificationWorker.perform_async(original_status.account_id, reaction.id, 'StatusReaction', 'reaction')
true
# account tried to react with disabled custom emoji. Returning true to discard activity.
rescue ActiveRecord::RecordInvalid
true
end
end