独自機能の追加などで他の部分への影響が分かるようにCI周りの修正 (#1)

* Fix EmojiFormatter failure

* Add notification_emails.warning setting default value

* Fix list spec failure and add antennas for spec response

* Fix domain block spec failure to add kb custom response

* Fix SearchQueryTransformer spec failure

* Fix Account#matches_display_name spec failure

* Fix UpdateStatusService changes mentions spec failure

* Fix RuboCop Lint

* Ignore brakeman warning

* Fix CI failure for ignore brakeman warning

* Fix migration failure

* Fix README

* Fix migration CI failure

* Fix some spec failure

* Format code for RuboCop lint failure

* Fix ESlint failure

* Fix haml-lint failure

app/javascript/mastodon/actions/antennas.js

@@ -1,4 +1,5 @@
 import api from '../api';
+
 import { importFetchedAccounts } from './importer';
 
 export const ANTENNAS_FETCH_REQUEST = 'ANTENNAS_FETCH_REQUEST';

app/javascript/mastodon/actions/emoji_reactions.js

@@ -1,4 +1,5 @@
 import api, { getLinks } from '../api';
+
 import { importFetchedStatuses } from './importer';
 
 export const EMOJI_REACTED_STATUSES_FETCH_REQUEST = 'EMOJI_REACTED_STATUSES_FETCH_REQUEST';

app/javascript/mastodon/components/emoji_view.jsx

@@ -1,5 +1,6 @@
-import { PureComponent } from 'react';
 import PropTypes from 'prop-types';
+import { PureComponent } from 'react';
+
 import emojify from '../features/emoji/emoji';
 
 export default class EmojiView extends PureComponent {

app/javascript/mastodon/components/short_number.tsx

@@ -33,7 +33,11 @@ export const ShortNumberRenderer: React.FC<ShortNumberProps> = ({
 
   const customRenderer = children ?? renderer ?? null;
 
-  const displayNumber = !isHide ? <ShortNumberCounter value={shortNumber} /> : <span>-</span>;
+  const displayNumber = !isHide ? (
+    <ShortNumberCounter value={shortNumber} />
+  ) : (
+    <span>-</span>
+  );
 
   return (
     customRenderer?.(displayNumber, pluralReady(value, division)) ??

app/javascript/mastodon/components/status_emoji_reactions_bar.jsx

@@ -1,8 +1,12 @@
-import { PureComponent } from 'react';
-import ImmutablePropTypes from 'react-immutable-proptypes';
 import PropTypes from 'prop-types';
+import { PureComponent } from 'react';
+
 import { injectIntl } from 'react-intl';
+
 import classNames from 'classnames';
+
+import ImmutablePropTypes from 'react-immutable-proptypes';
+
 import EmojiView from './emoji_view';
 
 class EmojiReactionButton extends PureComponent {

app/javascript/mastodon/features/antenna_adder/components/account.jsx

@@ -1,10 +1,12 @@
-import { connect } from 'react-redux';
-import { makeGetAccount } from '../../../selectors';
-import ImmutablePureComponent from 'react-immutable-pure-component';
+import { injectIntl } from 'react-intl';
+
 import ImmutablePropTypes from 'react-immutable-proptypes';
+import ImmutablePureComponent from 'react-immutable-pure-component';
+import { connect } from 'react-redux';
+
 import { Avatar } from '../../../components/avatar';
 import { DisplayName } from '../../../components/display_name';
-import { injectIntl } from 'react-intl';
+import { makeGetAccount } from '../../../selectors';
 
 const makeMapStateToProps = () => {
   const getAccount = makeGetAccount();

app/javascript/mastodon/features/antenna_adder/components/antenna.jsx

@@ -1,12 +1,16 @@
 import PropTypes from 'prop-types';
-import { connect } from 'react-redux';
-import ImmutablePureComponent from 'react-immutable-pure-component';
-import ImmutablePropTypes from 'react-immutable-proptypes';
-import { IconButton } from '../../../components/icon_button';
+
 import { defineMessages, injectIntl } from 'react-intl';
-import { removeFromAntennaAdder, addToAntennaAdder } from '../../../actions/antennas';
+
+import ImmutablePropTypes from 'react-immutable-proptypes';
+import ImmutablePureComponent from 'react-immutable-pure-component';
+import { connect } from 'react-redux';
+
 import { Icon } from 'mastodon/components/icon';
 
+import { removeFromAntennaAdder, addToAntennaAdder } from '../../../actions/antennas';
+import { IconButton } from '../../../components/icon_button';
+
 const messages = defineMessages({
   remove: { id: 'lists.account.remove', defaultMessage: 'Remove from list' },
   add: { id: 'lists.account.add', defaultMessage: 'Add to list' },

app/javascript/mastodon/features/antenna_adder/index.jsx

@@ -1,12 +1,16 @@
 import PropTypes from 'prop-types';
-import ImmutablePropTypes from 'react-immutable-proptypes';
-import { connect } from 'react-redux';
-import ImmutablePureComponent from 'react-immutable-pure-component';
+
 import { injectIntl } from 'react-intl';
-import { setupAntennaAdder, resetAntennaAdder } from '../../actions/antennas';
+
+import ImmutablePropTypes from 'react-immutable-proptypes';
+import ImmutablePureComponent from 'react-immutable-pure-component';
+import { connect } from 'react-redux';
 import { createSelector } from 'reselect';
-import Antenna from './components/antenna';
+
+import { setupAntennaAdder, resetAntennaAdder } from '../../actions/antennas';
+
 import Account from './components/account';
+import Antenna from './components/antenna';
 // hack
 
 const getOrderedAntennas = createSelector([state => state.get('antennas')], antennas => {

app/javascript/mastodon/features/compose/containers/markdown_button_container.js

@@ -1,8 +1,10 @@
-import { connect } from 'react-redux';
-import TextIconButton from '../components/text_icon_button';
-import { changeComposeMarkdown } from '../../../actions/compose';
 import { injectIntl, defineMessages } from 'react-intl';
 
+import { connect } from 'react-redux';
+
+import { changeComposeMarkdown } from '../../../actions/compose';
+import TextIconButton from '../components/text_icon_button';
+
 const messages = defineMessages({
   marked: { id: 'compose_form.markdown.marked', defaultMessage: 'Markdown is enabled' },
   unmarked: { id: 'compose_form.markdown.unmarked', defaultMessage: 'Markdown is disabled' },

app/javascript/mastodon/features/emoji_reacted_statuses/index.jsx

@@ -1,10 +1,15 @@
-import { debounce } from 'lodash';
 import PropTypes from 'prop-types';
+
+import { defineMessages, injectIntl, FormattedMessage } from 'react-intl';
+
 import { Helmet } from 'react-helmet';
+
 import ImmutablePropTypes from 'react-immutable-proptypes';
 import ImmutablePureComponent from 'react-immutable-pure-component';
-import { defineMessages, injectIntl, FormattedMessage } from 'react-intl';
 import { connect } from 'react-redux';
+
+import { debounce } from 'lodash';
+
 import { addColumn, removeColumn, moveColumn } from 'mastodon/actions/columns';
 import { fetchEmojiReactedStatuses, expandEmojiReactedStatuses } from 'mastodon/actions/emoji_reactions';
 import ColumnHeader from 'mastodon/components/column_header';

app/javascript/mastodon/features/notifications/components/notification.jsx

@@ -446,7 +446,6 @@ class Notification extends ImmutablePureComponent {
 
   renderWarning (notification) {
     const { intl, unread } = this.props;
-    console.dir(notification);
 
     return (
       <HotKeys handlers={this.getHandlers()}>

app/javascript/mastodon/reducers/antenna_adder.js

@@ -1,4 +1,5 @@
 import { Map as ImmutableMap, List as ImmutableList } from 'immutable';
+
 import {
   ANTENNA_ADDER_RESET,
   ANTENNA_ADDER_SETUP,

app/javascript/mastodon/reducers/antenna_editor.js

@@ -1,4 +1,5 @@
 import { Map as ImmutableMap, List as ImmutableList } from 'immutable';
+
 import {
   ANTENNA_ACCOUNTS_FETCH_REQUEST,
   ANTENNA_ACCOUNTS_FETCH_SUCCESS,

app/javascript/mastodon/reducers/antennas.js

@@ -1,7 +1,8 @@
+import { Map as ImmutableMap, fromJS } from 'immutable';
+
 import {
   ANTENNAS_FETCH_SUCCESS,
 } from '../actions/antennas';
-import { Map as ImmutableMap, fromJS } from 'immutable';
 
 const initialState = ImmutableMap();